-
-
Notifications
You must be signed in to change notification settings - Fork 15
feat: automatic cluster detection #1068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
That was a quick implementation, didn't expect that! :) |
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Only one thing about error message left
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
let api: Api<Node> = Api::all(client.clone()); | ||
let nodes = api | ||
.list(&ListParams::default()) | ||
.await | ||
.context(ListNodesSnafu)?; | ||
let node = nodes.iter().next().context(EmptyKubernetesNodesListSnafu)?; | ||
let node_name = node.name_any(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can inject this through the downwards API instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
slick! forgot about that :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do a followup PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, good idea!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Fixes stackabletech/issues#662
Definition of Done Checklist
Author
Reviewer
Acceptance