Skip to content

Basic support for starters #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 10, 2022
Merged

Basic support for starters #1

merged 4 commits into from
May 10, 2022

Conversation

seancdavis
Copy link
Collaborator

This provides some super simple support for starters.

It also is a little safer in avoiding directory conflicts by appending a random string when using the default directory name.

Updated usage details in the README.

Testing

To test, checkout this branch, then run:

npm link
cd /some/empty/test/directory
create-stackbit-app ...

@seancdavis seancdavis requested a review from eladroz May 9, 2022 18:47
config.js Outdated
repoUrl: "https://github.com/stackbit-themes/nextjs-starter",
},
{
name: "ts-mui-nextjs",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make it into "ts-nextjs" and if needed we'll add other names and aliases later? (same as we don't say "tailwind" in the default one)
(yeah, we may want to change the repo name as well, but that's not a blocker)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eladroz
Copy link
Contributor

eladroz commented May 10, 2022

Other than the smallish comment above, LGTM and eager to roll out :-) (and try the zip approach later...)

@seancdavis seancdavis merged commit 10b2ae8 into main May 10, 2022
@seancdavis seancdavis deleted the support-starters branch May 10, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants