feat(extension): support config-based ordering #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Deploying tutorialkit-demo-page with
|
| Latest commit: |
043f5e6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f33a8823.tutorialkit-demo-page.pages.dev |
| Branch Preview URL: | https://joan-config-based-ordering.tutorialkit-demo-page.pages.dev |
Deploying tutorialkit-docs-page with
|
| Latest commit: |
043f5e6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a4c6aa88.tutorialkit-docs-page.pages.dev |
| Branch Preview URL: | https://joan-config-based-ordering.tutorialkit-docs-page.pages.dev |
Nemikolh
commented
Aug 7, 2024
Comment on lines
-122
to
-125
| "__esbuild-base": "esbuild ./src/extension.ts --bundle --outfile=dist/extension.js --external:vscode --format=cjs --platform=node", | ||
| "__dev": "pnpm run esbuild-base -- --sourcemap --watch", | ||
| "__vscode:prepublish": "pnpm run esbuild-base -- --minify", | ||
| "__build": "vsce package", |
There was a problem hiding this comment.
I removed those because I don't think we should use them? @sulco what do you think?
Nemikolh
commented
Aug 7, 2024
| lesson.name = parsedContent.data.title; | ||
| timeoutId = setTimeout(async () => { | ||
| loading = true; | ||
| await this.refresh(); |
There was a problem hiding this comment.
When a file is changed, we throw away everything and recalculate everything (lazily on a needed basis though).
This is pretty inefficient but very simple.
Ideally, I'd want to do something more fine-grained where we only update the element of the tree that need to. This should improve perf on really big tutorials with many many markdown files.
AriPerkkio
reviewed
Aug 8, 2024
AriPerkkio
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
It does not implement re-ordering via drag and drop (I'll do that in a follow up PR).
I simplified the TreeView so that it does not contains any logic regarding the data structure generation. This is now done entirely in
models/tree/load.ts(not a fan of this location but couldn't think of a better one). The logic no longer usefs.readdirSyncand instead usevscode.workspace.fsfunctions.Screen.Recording.2024-08-07.at.10.37.07.mov
Closes #188