Connection from task is not properly used when handling incoming task #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it as an array. Use the connection from the task or fallback to the default.
marickvantuil
added
the
safe-to-test
|
@marickvantuil Thanks for the quick merge! :D |
|
I've tagged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when an incoming task is handled, the "connection" attribute of the command is not properly fetched. There is code for it, it used to work, but after that it stopped working.
The problem: the
$commandis an array, but is treated like an object. I updated the code to treat is as an array and added a test for it.If you have any feedback please let me know so we can get this bug fixed quickly. (this bug is withholding me from properly using this package)