Skip to content

Convert reports to JSON #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .jshintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
dist/*
3 changes: 2 additions & 1 deletion .jshintrc
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
"JASMINE": true,
"JASMINE_ADAPTER": true,
"matchers": true,
"priv": true
"priv": true,
"JSON": true
}
}
4 changes: 2 additions & 2 deletions dist/stacktrace-with-polyfills.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/stacktrace-with-polyfills.min.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/stacktrace.js
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@
};
req.open('post', url);
req.setRequestHeader('Content-Type', 'application/json');
req.send({stack: stackframes});
req.send(JSON.stringify({stack: stackframes}));
});
}
};
Expand Down
2 changes: 1 addition & 1 deletion dist/stacktrace.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/stacktrace.min.js.map

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ var uglify = require('gulp-uglify');

var polyfills = [
'./node_modules/es6-promise/dist/es6-promise.js',
'./node_modules/json3/lib/json3.js',
'./polyfills.js'
];
var dependencies = [
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
"gulp-uglify": "^1.4.1",
"jasmine-node": "~1.14",
"jasmine-sinon": "^0.4.0",
"json3": "^3.3.2",
"karma": "^0.13.9",
"karma-chrome-launcher": "^0.2.0",
"karma-coverage": "^0.5.2",
Expand Down
3 changes: 2 additions & 1 deletion spec/stacktrace-spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,8 @@ describe('StackTrace', function () {
});
waits(100);
runs(function () {
expect(server.requests[0].requestBody).toEqual({stack: stackframes});
var expectedResponse = JSON.stringify({stack: stackframes});
expect(server.requests[0].requestBody).toEqual(expectedResponse);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can that still be too long? O_o

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm.. I'm guessing the default line length limit is 80.

Sorry about the annoying Hound stuff; don't worry about this kinda thing. I may just disable it since JSHint is part of the build anyway.

expect(server.requests[0].url).toEqual(url);
expect(callback).toHaveBeenCalledWith('OK');
expect(errback).not.toHaveBeenCalled();
Expand Down
2 changes: 1 addition & 1 deletion stacktrace.js
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@
};
req.open('post', url);
req.setRequestHeader('Content-Type', 'application/json');
req.send({stack: stackframes});
req.send(JSON.stringify({stack: stackframes}));
});
}
};
Expand Down