-
Notifications
You must be signed in to change notification settings - Fork 7
Add NER model variant with required fields #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request introduces a new NER (Named Entity Recognition) model variant with required fields. The changes primarily affect the configuration, base framework, data models, and main execution file. The new variant aims to simplify internal regex/CFG representations and provide an additional point of comparison for other libraries. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @adrianeboyd - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
I have no attachment to the name Some example results (just 1 run instead of 10, on an RTX A5000, I'm not sure what's going on with the LMFormatEnforcer latency):
The LMFormatEnforcer F1 is a lot higher than for the current NER (and my initial expectation was that required fields version would lower the performance). |
In order to have an NER model that is simpler for internal regex/CFG representations, add an NER variant that requires all fields and does not include a default value. In particular, this makes it possible to evaluate a version of NER for Outlines and provides an additional point of comparison for other libraries.
d8ae434
to
e5a0db6
Compare
In order to have an NER model that is simpler for internal regex/CFG representations, add an NER variant that requires all fields and does not include a default value.
In particular, this makes it possible to evaluate a version of NER for Outlines and provides an additional point of comparison for other libraries.
Summary by Sourcery
Add a new NER model variant 'ner_required_fields' to support simpler internal representations by requiring all fields without default values. Update configuration and experiment framework to accommodate this new task.
New Features:
Enhancements: