-
Notifications
You must be signed in to change notification settings - Fork 7
Add Formatron framework #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request introduces the Formatron framework, a new machine learning framework for various NLP tasks. The changes include adding configuration for the Formatron framework in the config.yaml file and implementing the FormatronFramework class in a new file. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @adrianeboyd - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider removing the commented-out code for the 'ner_required_fields' task if it's not being used. This will improve code cleanliness and readability.
- The fallback to a regex-based approach for multilabel classification due to issues with Formatron might be worth investigating further. Consider looking into why Formatron isn't handling this case well and potentially contributing a fix upstream.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Some example results (1 run instead of 10, on an RTX A5000):
|
Summary by Sourcery
Add the FormatronFramework to the project, enabling new tasks like multilabel classification and synthetic data generation with specific model configurations. Update the configuration file to include settings for the new framework.
New Features:
Enhancements: