Remove hal dependencies from the crate #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is tested on F042, L432, F303, F103. |
|
Sounds fantastic! |
therealprof
reviewed
Nov 11, 2019
examples/hal.rs
Outdated
Comment on lines
44
to
49
| pub type UsbBusType = UsbBus<Peripheral>; | ||
|
|
||
|
|
||
| fn main() -> ! { | ||
| loop {} | ||
| } |
There was a problem hiding this comment.
Uhm, it would be great if the example actually showed how to do some USB interaction instead of just initialising something. 😅
There was a problem hiding this comment.
This is a "library" example. I'm going to add actual USB examples to the corresponding hal libraries.
There was a problem hiding this comment.
Cool, disregard this comment then. 😀
mvirkkunen
approved these changes
Nov 12, 2019
This was referenced Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way
stm32-usbddoes not rely onstm32*-haldependencies, instead hals use this driver for the corresponding peripherals.See also: #14