serial refactoring #400
Merged
serial refactoring #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burrbull
reviewed
Feb 14, 2022
src/serial.rs
Outdated
Comment on lines
328
to
335
| self.usart.cr1.modify(|_r, w| { w | ||
| .m().bit(match config.wordlength { | ||
| WordLength::DataBits8 => false, | ||
| WordLength::DataBits9 => true, | ||
| }) | ||
| .ps().bit(parity_is_odd) | ||
| .pce().bit(parity_is_used) | ||
| }); |
There was a problem hiding this comment.
If you want to write it in 1 line you can use this way
Suggested change
| self.usart.cr1.modify(|_r, w| { w | |
| .m().bit(match config.wordlength { | |
| WordLength::DataBits8 => false, | |
| WordLength::DataBits9 => true, | |
| }) | |
| .ps().bit(parity_is_odd) | |
| .pce().bit(parity_is_used) | |
| }); | |
| self.usart.cr1.modify(|_r, w| { | |
| w.m().bit(match config.wordlength { | |
| WordLength::DataBits8 => false, | |
| WordLength::DataBits9 => true, | |
| }); | |
| w.ps().bit(parity_is_odd); | |
| w.pce().bit(parity_is_used) | |
| }); |
or rustfmt
There was a problem hiding this comment.
Thanks for the hint
|
LGTM. Please squash commits |
AndreySmirnov81
force-pushed
the
serial_refactoring
branch
from
bad675f to
7bb55f1
Compare
burrbull
approved these changes
Feb 14, 2022
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@burrbull