Carousel Arrows Accessibility Updates to Support Label Props #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the arrow buttons of the Carousel component are causing accessibility issues because the buttons are considered empty. There is no text or description that would allow a user without sight to understand the context and purpose of the button.
This update adds the ability to pass in 2 new props to the CarouselArrows component, specifically a "leftArrowLabel" and a "rightArrowLabel" prop and sets them as the aria-label attribute of the left and right arrows, respectively.
If no values are passed for these props, they will simply have the default values of "Previous" and "Next", giving the end user a better understanding of what the buttons do and ensuring that the buttons are never empty.