Skip to content

Fix carousel selected state and dots #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 3, 2021

Conversation

jasonadkison
Copy link
Contributor

@jasonadkison jasonadkison commented Apr 29, 2021

  • fixes an issue where the selected state was not properly calculated when looping through the first and last images in the set
  • fixes the selected carousel dots styling (css specificity issue)
  • fixes an issue where the first thumbnail could never have the selectedTab classname applied

@jasonadkison
Copy link
Contributor Author

jasonadkison commented Apr 29, 2021

@dijs please give this a review asap, thanks! Also CC @ianand, not sure who is leading the efforts here currently.

Copy link
Contributor

@dijs dijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just needs some comments.

@jasonadkison
Copy link
Contributor Author

Looks good. Just needs some comments.

@dijs I realized I couldn't easily explain what one-liner version was doing so I converted it into far simpler logic.

@dijs dijs merged commit 70b0930 into storefront-foundation:master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants