Skip to content

MediaCarousel functionality improvements #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 31, 2020
Merged

MediaCarousel functionality improvements #64

merged 5 commits into from
Mar 31, 2020

Conversation

kevhender
Copy link
Contributor

@kevhender kevhender commented Mar 20, 2020

  • Fix to correctly show images of varying heights/widths
  • Allow thumbnails to be displayed on any side of the main image
  • Ensure that pinch-to-zoom is functional
  • Ensure that applicable changes work for Amp

@kevhender kevhender added enhancement New feature or request in progress Work is still in progress labels Mar 20, 2020
@kevhender kevhender requested a review from dijs March 31, 2020 17:23
@@ -206,7 +245,7 @@ function MediaCarousel(props) {
}, [])

const body = (
<>
<div className={clsx(styles.root, !lightboxActive && isThumbsSide && styles.rootSideThumbs)}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe try the object conditional here

@kevhender kevhender merged commit a2b9e22 into master Mar 31, 2020
@kevhender kevhender deleted the kh-carousel branch March 31, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request in progress Work is still in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants