[SQL] Add default SQL syntax selector command #4279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a naive command for users to choose default SQL dialect to be assigned to `source.sql`. The `sql_set_default_syntax` basically works for any syntax, but is prefixed `sql_` as it is located in and dedicated to SQL syntax package. Alternatively a general purpose `set_default_syntax` could be implemented by ST core or Default package. Ideally, dialect syntaxes could be identified by attributes in `Syntax()` class, but until this becomes true, rely on a static list of files specified via `dialect_file` argument to choose from.
deathaxe
force-pushed
the
pr/sql/add-dialect-chooser
branch
from
2f27ffd to
01634dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a naive command for users to choose default SQL dialect to be assigned to
source.sql.The
sql_set_default_syntaxbasically works for any syntax, but is prefixedsql_as it is located in and dedicated to SQL syntax package.Alternatively a general purpose
set_default_syntaxcould be implemented by ST core or Default package.Ideally, dialect syntaxes could be identified by attributes in
Syntax()class, but until this becomes true, rely on a static list of files specified viadialect_fileargument to choose from.FWIW, Right now SQL seems to be the only use case for what is called a "dialect".