Skip to content

fix: add integer to the list of numeric types #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

psteinroe
Copy link
Contributor

What kind of change does this PR introduce?

bug fix

What is the current behavior?

the return type integer of a function is unknown

What is the new behavior?

integer is correctly parsed as number

@psteinroe psteinroe requested review from a team as code owners November 2, 2023 13:50
@kevcodez kevcodez merged commit 07a1e4c into supabase:master Nov 2, 2023
@soedirgo
Copy link
Member

soedirgo commented Nov 3, 2023

Can you provide a test case for this? I'm not able to reproduce this issue:

postgres=# create function f() returns integer language sql as 'select 1';
CREATE FUNCTION
...
      f: {
        Args: Record<PropertyKey, never>
        Returns: number
      }
...

Note that an integer return type would show up as int4 in this case, they're equivalent: https://www.postgresql.org/docs/current/datatype-numeric.html#DATATYPE-INT

avallete pushed a commit that referenced this pull request May 13, 2025
This reverts commit 92df521.

The issue the above commit is meant to fix is probably fixed by #624.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants