[lldb/crashlog] Fix test failure when creating a target using command options (llvm#91653)

medismailben · medismailben · commit e3ec0809136a · 2024-05-14T09:16:29.000-07:00
This should fix the various crashlog test failures on the bots: ``` lldb-shell :: ScriptInterpreter/Python/Crashlog/app_specific_backtrace_crashlog.test lldb-shell :: ScriptInterpreter/Python/Crashlog/interactive_crashlog_json.test lldb-shell :: ScriptInterpreter/Python/Crashlog/interactive_crashlog_legacy.test lldb-shell :: ScriptInterpreter/Python/Crashlog/last_exception_backtrace_crashlog.test lldb-shell :: ScriptInterpreter/Python/Crashlog/skipped_status_interactive_crashlog.test ``` When we create a target by using the command option, we don't set it in the crashlog object which later on cause us to fail loading the images. rdar://127832961 Signed-off-by: Med Ismail Bennani <ismail@bennani.ma> (cherry picked from commit db94213)
diff --git a/lldb/examples/python/crashlog.py b/lldb/examples/python/crashlog.py
@@ -1490,6 +1490,7 @@ def load_crashlog_in_scripted_process(debugger, crashlog_path, options, result):
             raise InteractiveCrashLogException(
                 "couldn't create target provided by the user (%s)" % options.target_path
             )
+        crashlog.target = target
 
     # 2. If the user didn't provide a target, try to create a target using the symbolicator
     if not target or not target.IsValid():

Original file line number	Diff line number	Diff line change
`@@ -1490,6 +1490,7 @@ def load_crashlog_in_scripted_process(debugger, crashlog_path, options, result):`
`1490`	`1490`	`raise InteractiveCrashLogException(`
`1491`	`1491`	`"couldn't create target provided by the user (%s)" % options.target_path`
`1492`	`1492`	`)`
	`1493`	`+ crashlog.target = target`
`1493`	`1494`
`1494`	`1495`	`# 2. If the user didn't provide a target, try to create a target using the symbolicator`
`1495`	`1496`	`if not target or not target.IsValid():`