Unify request naming #208
Merged
Unify request naming #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
force-pushed
the
unify-request-naming
branch
from
8da5fb8 to
d50df1e
Compare
|
@swift-ci Please test |
Request types should always have the suffix Request and notifications should end with Notification. Also moved all request and notification types into separate folders to reduce the number of files in the LanguageServerProtocol folder.
ahoppen
force-pushed
the
unify-request-naming
branch
from
d50df1e to
e2d7eed
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The naming of notification and request types was inconsistent so far, sometimes having a
Requestsuffix and sometimes missing it.This PR makes the naming consistent with requests always having the
Requestsuffix and notifications always having theNotificationsuffix.It also moves the request types into their own folder and the notification types as well. Some files were split up to allow that separation (e.g.
ShutdownRequestandExitNotificationnow live in different files).The only weird naming that came out of this naming scheme is
CancelRequestNotificationsinceCancelRequestis the name of the notification as described in the LSP spec.Renames
Requests
DocumentFormatting->DocumentFormattingRequestDocumentRangeFormatting->DocumentRangeFormattingRequestDocumentOnTypeFormatting->DocumentOnTypeFormattingRequestPollIndex->PollIndexRequestNotifications
Exit->ExitNotificationCancelRequest->CancelRequestNotificationLogMessage->LogMessageNotificationDidChangeConfiguration->DidChangeConfigurationNotificationDidChangeWorkspaceFolders->DidChangeWorkspaceFoldersNotificationDidOpenTextDocument->DidOpenTextDocumentNotificationDidCloseTextDocument->DidCloseTextDocumentNotificationDidChangeTextDocument->DidChangeTextDocumentNotificationDidSaveTextDocument->DidSaveTextDocumentNotificationWillSaveTextDocument->WillSaveTextDocumentNotificationPublishDiagnostics->PublishDiagnosticsNotification