Update capability definitions to LSP 3.17 #671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlangmuir
reviewed
Nov 28, 2022
|
|
||
| public init(openClose: Bool? = true, | ||
| change: TextDocumentSyncKind? = .incremental, | ||
| willSave: Bool? = true, | ||
| willSaveWaitUntil: Bool? = false, |
There was a problem hiding this comment.
I'm confused about what happened here. These fields were specified in LSP 3.14, but removed in 3.15 from the interface declaration. But they're still mentioned on the request itself, e.g.
Server Capability:
- property name (optional): textDocumentSync.willSaveWaitUntil
- property type: boolean
There was a problem hiding this comment.
It turns out the spec has two definitions of TextDocumentSyncKind:
- Without
changeand friends: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocumentSyncOptions - With
changeand friends (scroll down a little from the link): https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_didRename
Since VSCode still has the options (https://github.com/microsoft/vscode-languageserver-node/blob/f02ec883a68c6ee0e07a512c2114847f5f8c9d29/protocol/src/common/protocol.ts#L1697) let’s continue to include them.
ahoppen
force-pushed
the
ahoppen/update-capabilities
branch
from
fa7ab55 to
86df3dd
Compare
benlangmuir
approved these changes
Nov 29, 2022
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/update-capabilities
branch
from
86df3dd to
ece67c7
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/update-capabilities
branch
from
ece67c7 to
5c77130
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/update-capabilities
branch
from
5c77130 to
975286d
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the definitions of the client and server capabilities to match LSP spec version 3.17.