Skip to content

Re-enable SwiftInterfaceTests.testSystemModuleInterface #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jul 13, 2023

My hypothesis is that testSystemModuleInterface has been flaky because of a malformed global module cache that might still be present from previous CI runs. If we use a local module cache, we define away that source of bugs.

rdar://104871745

@ahoppen ahoppen requested a review from bnbarham July 13, 2023 06:58
@ahoppen ahoppen requested a review from benlangmuir as a code owner July 13, 2023 06:58
@ahoppen
Copy link
Member Author

ahoppen commented Jul 13, 2023

@swift-ci Please test

@ahoppen ahoppen force-pushed the ahoppen/test-system-module-interface branch from 52e1aa7 to 4ff6e6a Compare July 13, 2023 06:58
@ahoppen
Copy link
Member Author

ahoppen commented Jul 13, 2023

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Jul 14, 2023

@swift-ci Please test macOS

@ahoppen
Copy link
Member Author

ahoppen commented Jul 14, 2023

@swift-ci Please test Windows

@ahoppen ahoppen force-pushed the ahoppen/test-system-module-interface branch from 4ff6e6a to c1a22c6 Compare July 17, 2023 15:58
@ahoppen
Copy link
Member Author

ahoppen commented Jul 17, 2023

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Jul 17, 2023

@swift-ci Please test Windows

@ahoppen ahoppen force-pushed the ahoppen/test-system-module-interface branch from c1a22c6 to 4780dfe Compare July 17, 2023 16:58
My hypothesis is that `testSystemModuleInterface` has been flaky because of a malformed global module cache that might still be present from previous CI runs. If we use a local module cache, we define away that source of bugs.

rdar://104871745
@ahoppen ahoppen force-pushed the ahoppen/test-system-module-interface branch from 4780dfe to a7cf7aa Compare July 17, 2023 16:58
@ahoppen
Copy link
Member Author

ahoppen commented Jul 17, 2023

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Jul 17, 2023

@swift-ci Please test Windows

@ahoppen ahoppen merged commit ee269d3 into swiftlang:main Jul 17, 2023
@ahoppen ahoppen deleted the ahoppen/test-system-module-interface branch July 17, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants