Skip to content

Don't use Core Foundation in tests. #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

grynspan
Copy link
Contributor

This PR removes a dependency on Core Foundation in a couple of our tests. The dependency is unnecessary and causes linkage issues on Windows per @etcwilde.

Resolves rdar://116586683.

This PR removes a dependency on Core Foundation in a couple of our tests. The dependency is unnecessary and causes linkage issues on Windows per @etcwilde.

Resolves rdar://116586683.
Copy link
Member

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@compnerd
Copy link
Member

@swift-ci please test

@grynspan
Copy link
Contributor Author

@swift-ci please test Windows

@etcwilde
Copy link
Member

Windows failure:

[165/165][100%][2.717s] Linking C static library lib\libcurl.lib
-- Install configuration: "Release"
-- Installing: T:/Library/curl-8.4.0/usr/lib/x64/libcurl.lib
-- Installing: T:/Library/curl-8.4.0/usr/bin/x64/curl-config
-- Installing: T:/Library/curl-8.4.0/usr/lib/x64/pkgconfig/libcurl.pc
-- Installing: T:/Library/curl-8.4.0/usr/include/curl
-- Installing: T:/Library/curl-8.4.0/usr/include/curl/curl.h
-- Installing: T:/Library/curl-8.4.0/usr/include/curl/curlver.h
-- Installing: T:/Library/curl-8.4.0/usr/include/curl/easy.h
-- Installing: T:/Library/curl-8.4.0/usr/include/curl/header.h
-- Installing: T:/Library/curl-8.4.0/usr/include/curl/mprintf.h
-- Installing: T:/Library/curl-8.4.0/usr/include/curl/multi.h
-- Installing: T:/Library/curl-8.4.0/usr/include/curl/options.h
-- Installing: T:/Library/curl-8.4.0/usr/include/curl/stdcheaders.h
-- Installing: T:/Library/curl-8.4.0/usr/include/curl/system.h
-- Installing: T:/Library/curl-8.4.0/usr/include/curl/typecheck-gcc.h
-- Installing: T:/Library/curl-8.4.0/usr/include/curl/urlapi.h
-- Installing: T:/Library/curl-8.4.0/usr/include/curl/websockets.h
-- Installing: T:/Library/curl-8.4.0/usr/lib/x64/cmake/CURL/CURLTargets.cmake
-- Installing: T:/Library/curl-8.4.0/usr/lib/x64/cmake/CURL/CURLTargets-release.cmake
-- Installing: T:/Library/curl-8.4.0/usr/lib/x64/cmake/CURL/CURLConfigVersion.cmake
-- Installing: T:/Library/curl-8.4.0/usr/lib/x64/cmake/CURL/CURLConfig.cmake
[0/1][  0%][0.024s] Install the project...
[2023-11-27 23:16:03] Finished building 'C:\Users\swift-ci\jenkins\workspace\swift-corelibs-xctest-PR-windows\curl' to 'T:\x64\curl-8.4.0' for arch 'x64' in 00:00:36.4609283

Copy-Item : Could not find a part of the path 
'C:\Users\swift-ci\jenkins\workspace\swift-corelibs-xctest-PR-windows\icu\icu4c\'.
At C:\Users\swift-ci\jenkins\workspace\swift-corelibs-xctest-PR-windows\swift\utils\build.ps1:990 char:7
+       Copy-Item $SourceCache\swift-installer-scripts\shared\ICU\CMake ...
+       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Copy-Item], DirectoryNotFoundException
    + FullyQualifiedErrorId : System.IO.DirectoryNotFoundException,Microsoft.PowerShell.Commands.CopyItemCommand

@compnerd, any ideas? Looks like build.ps1 is trying to copy something that didn't get installed?

@grynspan
Copy link
Contributor Author

@swift-ci please clean test Windows

@grynspan
Copy link
Contributor Author

grynspan commented Dec 4, 2023

@swift-ci please test Windows

@grynspan
Copy link
Contributor Author

grynspan commented Dec 7, 2023

@compnerd Do we know why this is failing? :(

@compnerd
Copy link
Member

compnerd commented Dec 7, 2023

Hmm, this might be a jenkins configuration thing? CC: @shahmishal

@grynspan
Copy link
Contributor Author

grynspan commented Jan 3, 2024

@swift-ci please test Windows

@grynspan
Copy link
Contributor Author

grynspan commented Jan 4, 2024

Yay!

@grynspan grynspan merged commit ea5c74d into main Jan 4, 2024
@grynspan grynspan deleted the jgrynspan/116586683-no-core-foundation branch January 4, 2024 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants