-
Notifications
You must be signed in to change notification settings - Fork 263
Don't use Core Foundation in tests. #471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR removes a dependency on Core Foundation in a couple of our tests. The dependency is unnecessary and causes linkage issues on Windows per @etcwilde. Resolves rdar://116586683.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks.
@swift-ci please test |
@swift-ci please test Windows |
Windows failure:
@compnerd, any ideas? Looks like build.ps1 is trying to copy something that didn't get installed? |
@swift-ci please clean test Windows |
@swift-ci please test Windows |
@compnerd Do we know why this is failing? :( |
Hmm, this might be a jenkins configuration thing? CC: @shahmishal |
@swift-ci please test Windows |
Yay! |
This PR removes a dependency on Core Foundation in a couple of our tests. The dependency is unnecessary and causes linkage issues on Windows per @etcwilde.
Resolves rdar://116586683.