Fix line breaking for attributes in inheritance clauses by grouping them with their type #1039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TTOzzi
requested review from
allevato,
bnbarham,
hamishknight and
rintaro
as code owners
allevato
reviewed
Jun 23, 2025
| @@ -2357,7 +2357,9 @@ fileprivate final class TokenStreamCreator: SyntaxVisitor { | |||
| } | |||
|
|
|||
| override func visit(_ node: InheritedTypeSyntax) -> SyntaxVisitorContinueKind { | |||
| before(node.firstToken(viewMode: .sourceAccurate), tokens: .open) | |||
There was a problem hiding this comment.
Can you move this new logic into the visit method for AttributedTypeSyntax instead? Then it we'll get the grouping in a bunch of other places that we have attributed/modified types, like @Sendable () -> Void or consuming T, not just in inheritance lists.
There was a problem hiding this comment.
Thank you for the feedback! I've applied the changes.
TTOzzi
force-pushed
the
encapsulating-inherited-type
branch
from
6b77fa9 to
3041452
Compare
allevato
reviewed
Jun 26, 2025
| cmp: @escaping (R) -> | ||
| () | ||
| cmp: | ||
| @escaping (R) -> () |
There was a problem hiding this comment.
Nice! I was hoping we'd find some others with that change.
allevato
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1032