Remove temp_await from Build/BuildPlan/*Command/Workspace
#7851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewHoos
requested review from
bnbarham,
MaxDesiatov,
jakepetroules,
francescomikulis and
xedin
as code owners
MaxDesiatov
changed the title
temp_await [part 5]temp_await from Build/BuildPlan/Commands/Workspace
MaxDesiatov
changed the title
temp_await from Build/BuildPlan/Commands/Workspacetemp_await from Build/BuildPlan/*Command/Workspace
|
@swift-ci test |
MaxDesiatov
added
build system
MaxDesiatov
reviewed
Aug 2, 2024
There was a problem hiding this comment.
This one needs import _Concurrency at the top to build with CMake/XCBuild
MaxDesiatov
approved these changes
Aug 2, 2024
|
@swift-ci test |
|
@swift-ci test windows |
AndrewHoos
force-pushed
the
deprecateTempAwait5
branch
from
9cdf3bf to
d8183c5
Compare
|
@swift-ci test |
|
@swift-ci test windows |
AndrewHoos
force-pushed
the
deprecateTempAwait5
branch
from
d8183c5 to
184bd1c
Compare
|
@swift-ci test windows |
|
@swift-ci test windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
temp_awaitfrom build related codeMotivation:
temp_awaitis unsafe and it would be better to use true async methodsModifications:
Remove
temp_awaitfrom BuildPlanRemove
temp_awaitfrom BuildOperationResult:
Safer more modern Swift code