Skip to content

[6.1] Fix build warnings in the Examples package #2914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2024
Merged

[6.1] Fix build warnings in the Examples package #2914

merged 1 commit into from
Dec 12, 2024

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Dec 10, 2024

  • Explanation: The Examples package had compiler warnings and we require that there are no warnings in swift-syntax so we can tag a (pre)release. Fix those warnings.
  • Scope: Only example code
  • Risk: None, examples don’t get build as part of the toolchain
  • Testing: Verified that it builds without warnings with this code.
  • Issue: n/a
  • Reviewer: @bnbarham

@ahoppen ahoppen requested a review from bnbarham as a code owner December 10, 2024 19:27
@ahoppen
Copy link
Member Author

ahoppen commented Dec 10, 2024

@swift-ci Please test

@ahoppen ahoppen changed the title Fix build warnings in the Examples package [6.1] Fix build warnings in the Examples package Dec 11, 2024
@ahoppen ahoppen merged commit 41bde9e into swiftlang:release/6.1 Dec 12, 2024
3 checks passed
@ahoppen ahoppen deleted the 6.1/fix-example-warnings branch December 12, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahoppen @bnbarham