Skip to content

AssociatedTypeInference: Allow inference in compatible constrained extensions #30712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2020

Conversation

AnthonyLatsis
Copy link
Collaborator

Since we allow associated type inference in regular extensions of the conforming nominal, we should also allow inference in extensions whose requirements are satisfied by those of the conformance context.

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

@AnthonyLatsis
Copy link
Collaborator Author

Linux failure is unrelated

@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test Linux

@CodaFi
Copy link
Contributor

CodaFi commented Mar 31, 2020

All of this seems very reasonable

@swift-ci test source compatibility

@AnthonyLatsis AnthonyLatsis force-pushed the constrained-inference branch from db5e7f3 to f5cf8cd Compare April 23, 2020 05:03
@AnthonyLatsis
Copy link
Collaborator Author

@swift-ci please smoke test

@AnthonyLatsis
Copy link
Collaborator Author

@CodaFi Are you qualified to review this change?

@AnthonyLatsis
Copy link
Collaborator Author

@DougGregor Any chance you have time to give us some feedback?

@slavapestov slavapestov merged commit c3d93d2 into swiftlang:master May 14, 2020
@AnthonyLatsis AnthonyLatsis deleted the constrained-inference branch May 14, 2020 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants