Use correct associated context for SIL parsing #31690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the integrated REPL has been removed, there is always an associated decl context, and we can assert as such.
Rather than maintain a separate bit, check if the associated decl context is for the ModuleDecl.
Adjust `SILModule::createEmptyModule` to accept a FileUnit or ModuleDecl, and pass the corresponding context for SIL generation and parsing. This change means that SIL parsing will now correctly use a SourceFile associated context when in single-file mode.
hamishknight
force-pushed
the
guilt-by-association
branch
from
a472c58 to
574dd2b
Compare
|
@swift-ci please test |
slavapestov
approved these changes
May 13, 2020
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust
SILModule::createEmptyModuleto accept aFileUnitorModuleDecl, and pass the corresponding context for SIL generation and parsing. This change means that SIL parsing will now correctly use aSourceFileassociated context when in single-file mode.In addition, tighten up some invariants around
SILModuleconstruction.