Skip to content

[Sema] Fix raw layout deserialization #68001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2023
Merged

Conversation

Azoy
Copy link
Contributor

@Azoy Azoy commented Aug 18, 2023

If we happened to serialize a type with @_rawLayout(like: T) then deserializing it would come with a canonical fixed type representation with archetypes and using the like type request would unconditionally call into the type resolver when we've already sort of resolved this type.

@Azoy Azoy requested a review from jckarter August 18, 2023 03:01
@Azoy
Copy link
Contributor Author

Azoy commented Aug 18, 2023

@swift-ci please test

@Azoy
Copy link
Contributor Author

Azoy commented Aug 18, 2023

@swift-ci please build toolchain

Update raw_layout.swift
@Azoy Azoy force-pushed the raw-deserialize branch from f162968 to dadbbb4 Compare August 19, 2023 03:36
@Azoy
Copy link
Contributor Author

Azoy commented Aug 19, 2023

@swift-ci please test

@Azoy
Copy link
Contributor Author

Azoy commented Aug 19, 2023

@swift-ci please test Linux

@Azoy Azoy merged commit d04d8c1 into swiftlang:main Aug 19, 2023
@Azoy Azoy deleted the raw-deserialize branch August 19, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant