LargeLoadable types: propagate large type property along projections #78321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Back propagate the isLargeType property along projections. This is neccessary because c union types can "hide" largeness. rdar://141775951
|
@swift-ci test |
|
@swift-ci test |
aschwaighofer
added a commit
to aschwaighofer/swift
that referenced
this pull request
Jan 2, 2025
…tions Explanation: Back propagate the isLargeType property along projections. This is neccessary because c union types can "hide" largeness. Without this change the compiler would crash because an operand of a projection (struct_extract, tuple_extract) would be deemed small but the projected element would be deemed large. The stack location for the operand would therefore be missing when lowering to addresses. Scope: Corner case involving large c type lowering. Risk: Medium. Should only affect c union types. Original PR: swiftlang#78321 rdar://141775951
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Back propagate the isLargeType property along projections. This is neccessary because c union types can "hide" largeness.
rdar://141775951