Codes examples colors

[Krazitchek]

Why changing what was good ?... new theme for codes samples rendering in documentation is less readable than "before" because of some dark font colors (dark blue) on black background...

[javiereguiluz]

We haven't made any recent change about that (at least on purpose!). Could you please share a screenshot of the problematic code listings? Thanks!

[Krazitchek]

In commit 8c84bb1 we read that JS and CSS was added.

What i did:

• Download last 2.7 documentation archive from github
• Build (make html) documentation with python-sphinx using fabpot/sphinx-php.git
• Copy assets directory in generated html directory to get css and js
• Launch index.html

In browser console i see this error: TypeError: $.getQueryParameters is not a function

Screenshot before:

Same screenshot now:

[javiereguiluz]

I honestly don't understand what's going on here. I literally took the same CSS and JS files used on symfony.com and added to the repo. Could you please use the browser's inspector on the code which shows a wrong highlight and see if it's because of some missing style or some missing CSS, etc. Thanks!

[Krazitchek]

Maybe i do the wrongs things to get the documentation for offline reading (no internet at work, yes, it's possible in 2018 !).
It will be intersting to know if i'm the only one to experiment this case.
All i can see in browser console is this error: TypeError: $.getQueryParameters is not a function.

[javiereguiluz]

@Krazitchek in #9972 we've switched the default theme used to build docs locally. Now it doesn't look like symfony.com at all ... but at least everything works and the generated docs are fully usable. That's why I'm closing this issue. Thanks!