Skip to content

[Reference] updated framework config reference #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2013
Merged

[Reference] updated framework config reference #2241

merged 1 commit into from
Feb 19, 2013

Conversation

1ed
Copy link
Contributor

@1ed 1ed commented Feb 16, 2013

Q A
Doc fix? yes
New docs? no
Applies to 2.2-RC2+
Fixed tickets -

This was generated by the php app/console config:dump-reference framework command.

Maybe these config sections should be removed and just add a note how to generate them.

@stof
Copy link
Member

stof commented Feb 17, 2013

@1ed they should not be removed IMO. Having them in the doc is easier for people searching for it

weaverryan added a commit that referenced this pull request Feb 19, 2013
[Reference] updated framework config reference
@weaverryan weaverryan merged commit 8a8ea6f into symfony:master Feb 19, 2013
@weaverryan
Copy link
Member

Yea, these reference sections are tricky, but we keep them for 2 reasons:

  1. As @stof noted, it makes them searchable
  2. We can add additional details that the generator can't get to. This can include comments, but also "more correct" default values in some cases (e.g. something defaults to null but the service it feeds into defaults that argument to foo, making foo the somewhat "most correct" default value.

This is great though, thanks for the update! This will need to be part of an ongoing maintenance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants