Show controller tag for PHP configuration #8797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Putting the tag in the PHP documentation is necessary so that controllers are marked as public to avoid a deprecation notice and also to wire them up the same way as controllers configured via xml or yml would be.
yceruto
approved these changes
Dec 1, 2017
| @@ -373,7 +373,8 @@ The third big change is that, in a new Symfony 3.3 project, your controllers are | |||
| // app/config/services.php | |||
|
|
|||
| // ... | |||
|
|
|||
|
|
|||
| $definition->addTag('controller.service_arguments'); | |||
| $this->registerClasses($definition, 'AppBundle\\Controller\\', '../../src/AppBundle/Controller/*'); | |||
There was a problem hiding this comment.
It does not matter, but would it look better if we add the tag after the classes registration? i.e the same natural order that yaml and xml formats.
There was a problem hiding this comment.
But then the tag wouldn't be picked up inside registerClasses() where the past Definition instance is used as a prototype.
javiereguiluz
approved these changes
Dec 1, 2017
|
A very subtle bug fix. The best kind! Thank you Joe! |
weaverryan
added a commit
that referenced
this pull request
Dec 1, 2017
This PR was merged into the 3.3 branch. Discussion ---------- Show controller tag for PHP configuration Putting the tag in the PHP documentation is necessary so that controllers are marked as public to avoid a deprecation notice and also to wire them up the same way as controllers configured via xml or yml would be. Commits ------- 4ab96f6 Show controller tag for PHP configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting the tag in the PHP documentation is necessary so that controllers are marked as public to avoid a deprecation notice and also to wire them up the same way as controllers configured via xml or yml would be.