Popper js is required #9980
Closed
Popper js is required #9980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you don't add popper js you will probably have the following message while compiling with yarn This dependency was not found: * popper.js in ./node_modules/bootstrap/dist/js/bootstrap.js
royklutman
suggested changes
Jun 30, 2018
Changed popper to Popper.js
javiereguiluz
approved these changes
Jul 2, 2018
There was a problem hiding this comment.
In #9918 I told @Eoras
that we should probably remove Popper.js when installing Bootstrap (#9918 (comment)). It's clear now that I was wrong. I'm sorry and I thank you for fixing it. Thanks!
HeahDude
approved these changes
Jul 2, 2018
|
Nothing to add |
|
Didn't want to close sorry, not used to github yet |
|
@Etilawin thanks for fixing this! We merged it in 3.4 (the oldest maintained branch where this fix makes sense) and we'll merge in the upper branches automatically later. Congrats on your first Symfony Docs contribution! |
javiereguiluz
added a commit
that referenced
this pull request
Jul 2, 2018
This PR was submitted for the 4.1 branch but it was squashed and merged into the 3.4 branch instead (closes #9980). Discussion ---------- Popper js is required If you don't add popper js you will probably have the following message while compiling with yarn This dependency was not found: * popper.js in ./node_modules/bootstrap/dist/js/bootstrap.js <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- a09797a Popper js is required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you don't add popper js you will probably have the following message while compiling with yarn
This dependency was not found: