Skip to content

Add Thread::getId() to Thread::threadId() migration documentation #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dev-docs-github-app-dev[bot]
Copy link

This PR adds documentation regarding the migration from Thread::getId() to Thread::threadId() in OpenSearch 2.19.0 release notes. The update includes:

Key changes documented:

  • Added information about the replacement of deprecated Thread::getId() with Thread::threadId()
  • Clarified that this change is for Java 19 compatibility
  • Specified the scope of changes to prevent confusion with other getId() methods
  • Highlighted the benefits of this update for code maintenance

The documentation helps developers and users understand:

  1. The motivation behind the change (Java 19 compatibility)
  2. The scope of the changes (only affecting actual Thread usage)
  3. That domain-specific getId() methods are not affected
  4. The positive impact on code maintainability

Location: release-notes/opensearch-documentation-release-notes-2.19.0.md

This documentation helps users understand the technical changes while maintaining API clarity.

Copy link
Author

This pull request was created by AI Agent. Please review the changes and provide feedback. Context used:

                    ```json
                    {

"docsToCreate": [],
"docsToUpdate": [
{
"filePath": "release-notes/opensearch-documentation-release-notes-2.19.0.md",
"branch": "main"
}
],
"relevantCodeFiles": [
{
"branch": "main",
"filePath": "libs/common/src/test/java/org/opensearch/common/recycler/ConcurrentRecyclerTests.java"
},
{
"branch": "main",
"filePath": "libs/common/src/test/java/org/opensearch/common/recycler/QueueRecyclerTests.java"
}
],
"relevantCodeRepo": "opensearch-project/OpenSearch",
"relevantDocsFiles": [
{
"filePath": "release-notes/opensearch-documentation-release-notes-2.19.0.md",
"branch": "main"
}
]
}
```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants