Skip to content
This repository was archived by the owner on Apr 23, 2025. It is now read-only.

[WordSeg] Add example #526

Merged
merged 3 commits into from
May 14, 2020
Merged

Conversation

texasmichelle
Copy link
Member

No description provided.

Copy link
Contributor

@asuhan asuhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@BradLarson BradLarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great (assuming the test failure is flaky and can be resolved). We should make a note of the NaN testing case as a future callback we need for the unified training loop. Keras has this as a callback, and I can see other models using that.

Add support for user-defined datasets
Update readme with usage for new options
@texasmichelle
Copy link
Member Author

The test failure is indeed puzzling. My hunch is that kokoro was using a cached image, so I'm curious to see whether it passes without any changes to TextUnsupervised.

Do we have an open issue for training loop creation? Would that be here or in another repo?

@texasmichelle
Copy link
Member Author

I couldn't get past the first epoch with the full dataset, so I added support for a smaller dataset, which trains quickly. The full dataset gives us our performance target and the flexibility to use a smaller sample will help get us there.

@texasmichelle texasmichelle merged commit b6e9eaf into tensorflow:master May 14, 2020
@texasmichelle texasmichelle deleted the wordseg_example branch May 14, 2020 17:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants