-
Notifications
You must be signed in to change notification settings - Fork 469
feat(waitForElement): a wrapper around MutationObserver #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kentcdodds
merged 8 commits into
testing-library:master
from
sompylasar:pr/wait-mutation-observer
Apr 9, 2018
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
63347eb
feat(waitForElements): add implementation, tests, docs
sompylasar 5c40618
docs(contributors): update sompylasar
sompylasar 1f46848
CR changes
sompylasar 88bab87
fix(waitForElement): ensure it works with default callback
sompylasar b7158cf
CR: tweak docs examples for wait and waitForElement
sompylasar 1252d08
CR: rename files to kebab-case
sompylasar 414a3dc
CR: await promise -> return promise
sompylasar edfb241
CR: shorter timeouts and wait times for quicker tests
sompylasar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| // Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
|
||
| exports[ | ||
| `it returns immediately if the callback returns the value before any mutations 1` | ||
| ] = ` | ||
| <div | ||
| data-test-attribute="something changed once" | ||
| > | ||
| <div | ||
| data-testid="initial-element" | ||
| /> | ||
| </div> | ||
| ` | ||
|
|
||
| exports[`it throws if timeout is exceeded 1`] = ` | ||
| Array [ | ||
| [Error: Timed out in waitForElement.], | ||
| ] | ||
| ` | ||
|
|
||
| exports[`it throws if timeout is exceeded 2`] = ` | ||
| <div | ||
| data-test-attribute="something changed twice" | ||
| /> | ||
| ` | ||
|
|
||
| exports[ | ||
| `it throws the same error that the callback has thrown if timeout is exceeded 1` | ||
| ] = ` | ||
| Array [ | ||
| [Error: Unable to find an element by: [data-testid="test"]], | ||
| ] | ||
| ` | ||
|
|
||
| exports[ | ||
| `it throws the same error that the callback has thrown if timeout is exceeded 2` | ||
| ] = ` | ||
| <div | ||
| data-test-attribute="something changed twice" | ||
| /> | ||
| ` | ||
|
|
||
| exports[ | ||
| `it waits for the callback to return a value and only reacts to DOM mutations 1` | ||
| ] = ` | ||
| <div> | ||
| <div | ||
| data-testid="initial-element" | ||
| /> | ||
| <div | ||
| data-testid="another-element-that-causes-mutation-1" | ||
| /> | ||
| <div | ||
| data-testid="another-element-that-causes-mutation-2" | ||
| /> | ||
| <div | ||
| data-testid="another-element-that-causes-mutation-3" | ||
| /> | ||
| <div | ||
| data-testid="another-element-that-causes-mutation-4" | ||
| /> | ||
| <div | ||
| data-testid="another-element-that-causes-mutation-5" | ||
| /> | ||
| <div | ||
| data-testid="the-element-we-are-looking-for" | ||
| /> | ||
| </div> | ||
| ` | ||
|
|
||
| exports[`it waits for the next DOM mutation with default callback 1`] = ` | ||
| <body> | ||
| <div /> | ||
| </body> | ||
| ` | ||
|
|
||
| exports[`it waits for the next DOM mutation with default callback 2`] = ` | ||
| <body> | ||
| <div /> | ||
| </body> | ||
| ` |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a simple example of this. It's probably the most common use case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe just make the example above use it like that.