Improving api #13
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| const expect = require('expect') //eslint-disable-line import/no-extraneous-dependencies | ||
| const extensions = require('./dist/jest-extensions') | ||
|
|
||
| const {toBeInTheDOM, toHaveTextContent, toSatisfyDOM} = extensions.default | ||
| expect.extend({toBeInTheDOM, toHaveTextContent, toSatisfyDOM}) | ||
|
|
||
| module.exports = expect |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| const extensions = { | ||
| toBeInTheDOM(received) { | ||
| if (received) { | ||
| return { | ||
| message: () => 'expected the dom to be present', | ||
|
There was a problem hiding this comment. Rather than calling it "dom" call it "element." The Same below. |
||
| pass: true, | ||
| } | ||
| } else { | ||
| return { | ||
| message: () => 'expected the dom not to be present', | ||
| pass: false, | ||
| } | ||
| } | ||
| }, | ||
|
|
||
| toHaveTextContent(htmlElement, checkWith) { | ||
| const textContent = htmlElement.textContent | ||
|
There was a problem hiding this comment. Could we add an extra check here that throw new Error(`The given subject is a ${getDisplayName(htmlElement)}, not an HTMLElement`)Or return an object, but this should probably fail regardless of whether people use The function getDisplayName(subject) {
if (subject && subject.constructor) {
return subject.constructor.name
} else {
return typeof subject
}
}Or, maybe there's a better thing for this available on npm... There was a problem hiding this comment. I guess the code that you had mentioned |
||
| const pass = textContent === checkWith | ||
|
There was a problem hiding this comment. Could we extend this to use the Using the There was a problem hiding this comment. Yes, thats a good idea. Can take care of that, will move |
||
| if (pass) { | ||
| return { | ||
| message: () => `expected ${textContent} not equals to ${checkWith}`, | ||
|
There was a problem hiding this comment. Let's use |
||
| pass: true, | ||
| } | ||
| } else { | ||
| return { | ||
| message: () => `expected ${textContent} equals to ${checkWith}`, | ||
|
There was a problem hiding this comment. Let's use |
||
| pass: false, | ||
| } | ||
| } | ||
| }, | ||
|
|
||
| toSatisfyDOM(element, fn) { | ||
| const pass = fn(element) | ||
|
There was a problem hiding this comment. I think this should be more like this: https://github.com/jest-community/jest-extended/blob/master/src/matchers/toSatisfy/index.js In fact, it looks like we should probably be changing everything in this file to use |
||
| if (pass) { | ||
| return { | ||
| message: () => 'expected condition not equals to true', | ||
| pass: true, | ||
| } | ||
| } else { | ||
| return { | ||
| message: () => 'expected condition equals to true', | ||
| pass: false, | ||
| } | ||
| } | ||
| }, | ||
| } | ||
|
|
||
| export default extensions | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just disable this rule globally. It really annoys me and I should remove it from my base config eventually...
In the
package.json, update theeslintConfigto have arulesproperty that disables this rule 👍