docs: removing unnecessary variable in the fireEvent example #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 18 18
=====================================
Hits 18 18Continue to review full report at Codecov.
|
thchia
added a commit
to thchia/react-testing-library
that referenced
this pull request
Apr 11, 2018
… with it. docs: remove unnecessary variable in the fireEvent documentation (testing-library#51)
julienw
pushed a commit
to julienw/react-testing-library
that referenced
this pull request
Dec 20, 2018
There was an issue with a minor release, so this manual-releases.md change is to release a new minor version. Closes testing-library#51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Remove unnecessary variable in the fireEvent example
Why:
Keep the docs consistent.
How:
[x] removed the
unmountfromconst {unmount, getByText}Check:
[x] Documentation
[ ] Tests
[x] Ready to be merged
[x] Added myself to contributors table
Special thanks for my friend @aputhin that showed me this repo!!