svelte: update docs #1298
Merged
svelte: update docs #1298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
timdeschryver
commented
Aug 26, 2023
timdeschryver
commented
Aug 26, 2023
MatanBobi
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
This looks like a great improvement, thanks Tim :) I left two minor comments
As a general idea, it seems to me like we're covering some stuff here that should be covered in other library documentations (that's why we need to update it from time to time when API changes).
I'm not sure I have a good idea on how to solve it. As I said, this PR is an improvement from what we have so anyways I think it can be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.