Update dependencies and protobuf generation using Buf #9155
Conversation
nopcoder
added
dependencies
nopcoder
added
the
exclude-changelog
There was a problem hiding this comment.
Thanks - new build process looks neater (not just newer).
I don't understand (and this is not blocking, given that CI passes): where did the .pb.go files go? Are they now auto-generated? This would make me really happy 🥳 . But in that case - did we have no checks-validator check that we correctly updated them?
| GOLANGCI_LINT=github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.1.5 | ||
| BUF_CLI_VERSION=v1.28.1 | ||
| GOLANGCI_LINT=github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.1.6 | ||
| BUF_CLI_VERSION=v1.54.0 |
There was a problem hiding this comment.
This is really weird: the old Buf CLI version was the same as the action version, now they're different. Did they really do this??
There was a problem hiding this comment.
yes, I thought they will sync the version of the action with the version of the cli - but it is not the case.
| @@ -107,6 +107,7 @@ gen-docs: ## Generate CLI docs automatically | |||
| gen-metastore: ## Run Metastore Code generation | |||
| @thrift -r --gen go --gen go:package_prefix=github.com/treeverse/lakefs/pkg/metastore/hive/gen-go/ -o pkg/metastore/hive pkg/metastore/hive/hive_metastore.thrift | |||
|
|
|||
| .PHONY: tools | |||
|
We check-in the generated code and the CI verify that the checked-in generated code is aligned with the current tool's output. |
Fix #9153
Fix #9154