Updated bundle param to be nullable #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs specify that the `Bundle` param in the onActivityCreated function is nullable, so the override definition should match. Should fix viniciusmo#3
|
Please note that I have not verified build integrity after making this change |
|
Here's the relevant documentation |
|
Because this library seems to be abandoned, I have little hope of this PR ever being merged. I've forked the project, pulled in another useful fork and updated the readme content, if you need this fix feel free to use the fork repo instead of this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs specify that the
Bundleparam in the onActivityCreated function is nullable, so the override definition should match. Should fix #3