Skip to content

Build should fail if a class cannot be found #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yankee42 opened this issue Mar 7, 2019 · 2 comments
Closed

Build should fail if a class cannot be found #315

yankee42 opened this issue Mar 7, 2019 · 2 comments

Comments

@yankee42
Copy link

yankee42 commented Mar 7, 2019

I am using typescript generator as part of my build process using a maven plugin.

When a class cannot be found (e.g. because of a typo in the type name in pom.xml) then an error is printed, but the build continues. However this will naturally result in an incomplete output file which will cause some confusion when that incomplete file is used elsewhere.

It would make it easier to detect such an error early on by failing the build process and thus alerting the user.

The ClassNotFoundException is currently caught, printed and then ignored here:

@vojtechhabarta
Copy link
Owner

@yankee42 you are right, this is not optimal.
This behavior (continuing after error) was added as part of solving class loading problem (#142). I will consider to changing it, maybe it is not needed anymore.

@vojtechhabarta
Copy link
Owner

Released in v3.0.1157.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants