Add _target="blank" deprecation on <router-link>
#539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hogart
reviewed
Oct 24, 2016
| @@ -267,6 +267,8 @@ You'll need to update it like this: | |||
| <router-link to="/about">About</router-link> | |||
| ``` | |||
|
|
|||
| Note: `target="_blank"` is not supported on `<router-link>` component, please use `<a>` tags instead. | |||
There was a problem hiding this comment.
I think it would be nice to mention about router.match() here, so people won't get impression that manually maintaining URLs is recommended way.
There was a problem hiding this comment.
I think it's very rare that people want to open an app link in a new tab, then most people won't need this undocumented method at all.. So let's just keep the docs concise.
Peter-WF
pushed a commit
to Peter-WF/vuefe.github.io
that referenced
this pull request
Nov 18, 2016
* Add _target="blank" deprecation on `<router-link>` * Tweak language about route links in new tabs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.