Skip to content

[v2.0] Add spec to check if name is set on current route. #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[v2.0] Add spec to check if name is set on current route. #591

wants to merge 1 commit into from

Conversation

zigomir
Copy link
Contributor

@zigomir zigomir commented Jul 31, 2016

Re-opening #584 because it already became stale in the mean time.

Problem

name property of route (defined through router options) won't be transferred to component.$route.name as it was the case in previous versions of vue-router.

Added spec in this PR

This spec is intentionally failing because I don't know how to properly fix the bug. getLocation method in abstract.js was added so we can run this spec.

@zigomir zigomir changed the title Add spec to check if name is set on current route. [v2.0] Add spec to check if name is set on current route. Jul 31, 2016
yyx990803 added a commit that referenced this pull request Aug 5, 2016
@yyx990803 yyx990803 closed this Aug 5, 2016
@zigomir zigomir deleted the named-route branch August 5, 2016 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants