matching is not defined for strings #1451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titusfortner
requested review from
AutomatedTester,
jgraham and
shs96c
as code owners
andreastt
requested changes
Oct 15, 2019
titusfortner
force-pushed
the
matching
branch
from
03c1f6e to
7066cca
Compare
andreastt
approved these changes
Oct 16, 2019
andreastt
approved these changes
Oct 16, 2019
andreastt
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@andreastt based on your comment in #1445 I went through and looked for all of the times "matching" was used to refer to Strings. Let me know if any of these shouldn't be changed. Also, I'm unsure about https://github.com/w3c/webdriver/blob/master/index.html#L7133 but I think it is ok as is.
Preview | Diff