fix(client): default client fallback with redirection to all default directory files

client-src/default-redirect/index.js

@@ -0,0 +1,8 @@
+'use strict';
+
+/* global __resourceQuery */
+
+// eslint-disable-next-line import/no-unresolved, import/no-dynamic-require
+module.exports = require(`./default/index${
+  typeof __resourceQuery === 'string' ? __resourceQuery : ''
+}`);

client-src/default-redirect/overlay.js

@@ -0,0 +1,4 @@
+'use strict';
+
+// eslint-disable-next-line import/no-unresolved
+module.exports = require(`./default/overlay`);

client-src/default-redirect/socket.js

@@ -0,0 +1,4 @@
+'use strict';
+
+// eslint-disable-next-line import/no-unresolved
+module.exports = require(`./default/socket`);

client-src/default-redirect/utils/createSocketUrl.js

@@ -0,0 +1,4 @@
+'use strict';
+
+// eslint-disable-next-line import/no-unresolved
+module.exports = require(`../default/utils/createSocketUrl`);

client-src/default-redirect/utils/getCurrentScriptSource.js

@@ -0,0 +1,4 @@
+'use strict';
+
+// eslint-disable-next-line import/no-unresolved
+module.exports = require(`../default/utils/getCurrentScriptSource`);

client-src/default-redirect/utils/log.js

@@ -0,0 +1,4 @@
+'use strict';
+
+// eslint-disable-next-line import/no-unresolved
+module.exports = require(`../default/utils/log`);

client-src/default-redirect/utils/reloadApp.js

@@ -0,0 +1,4 @@
+'use strict';
+
+// eslint-disable-next-line import/no-unresolved
+module.exports = require(`../default/utils/reloadApp`);

client-src/default-redirect/utils/sendMessage.js

@@ -0,0 +1,8 @@
+'use strict';
+
+/* global __resourceQuery */
+
+// eslint-disable-next-line import/no-unresolved, import/no-dynamic-require
+module.exports = require(`../default/utils/sendMessage${
+  typeof __resourceQuery === 'string' ? __resourceQuery : ''
+}`);

client-src/default/socket.js

@@ -9,14 +9,10 @@
 // is off or the client is not injected. This will be switched to
 // WebsocketClient when it becomes the default
 
-// important: the path to SockJSClient here is made to work in the 'client'
-// directory, but is updated via the webpack compilation when compiled from
-// the 'client-src' directory
 const Client =
   typeof __webpack_dev_server_client__ !== 'undefined'
     ? __webpack_dev_server_client__
-    : // eslint-disable-next-line import/no-unresolved
-      require('./clients/SockJSClient');
+    : require('../clients/SockJSClient');
 
 let retries = 0;
 let client = null;

client-src/default/webpack.config.js

@@ -1,7 +1,5 @@
 'use strict';
 
-const webpack = require('webpack');
-
 module.exports = {
   mode: 'production',
   module: {
@@ -17,12 +15,4 @@ module.exports = {
       },
     ],
   },
-  plugins: [
-    new webpack.NormalModuleReplacementPlugin(/\/clients\//, (resource) => {
-      resource.request = resource.request.replace(
-        /\/clients\//,
-        '/../clients/'
-      );
-    }),
-  ],
 };

client-src/live/webpack.config.js

@@ -1,7 +1,6 @@
 'use strict';
 
 const path = require('path');
-const webpack = require('webpack');
 const CopyPlugin = require('copy-webpack-plugin');
 
 module.exports = {
@@ -34,11 +33,5 @@ module.exports = {
         to: path.resolve(__dirname, '../../client/live.html'),
       },
     ]),
-    new webpack.NormalModuleReplacementPlugin(/\/clients\//, (resource) => {
-      resource.request = resource.request.replace(
-        /\/clients\//,
-        '/../clients/'
-      );
-    }),
   ],
 };

package.json

@@ -25,7 +25,8 @@
     "test": "npm run test:coverage",
     "pretest": "npm run lint",
     "prepare": "rimraf ./ssl/*.pem && npm run build:client",
-    "build:client:default": "babel client-src/default --out-dir client --ignore \"./client-src/default/*.config.js\"",
+    "build:client:default": "babel client-src/default --out-dir client/default --ignore \"./client-src/default/*.config.js\"",
+    "build:client:default-redirect": "babel client-src/default-redirect --out-dir client",
     "build:client:clients": "babel client-src/clients --out-dir client/clients",
     "build:client:index": "webpack ./client-src/default/index.js -o client/index.bundle.js --color --config client-src/default/webpack.config.js",
     "build:client:live": "webpack ./client-src/live/index.js -o client/live.bundle.js --color --config client-src/live/webpack.config.js",

test/client/clients/SockJSClient.test.js

@@ -3,7 +3,7 @@
 const http = require('http');
 const express = require('express');
 const sockjs = require('sockjs');
-const SockJSClient = require('../../../client-src/clients/SockJSClient');
+const SockJSClient = require('../../../client/clients/SockJSClient');
 const port = require('../../ports-map').sockJSClient;
 
 describe('SockJSClient', () => {

test/client/index.test.js

@@ -17,45 +17,49 @@ describe('index', () => {
   const resourceQueryValue = global.__resourceQuery;
 
   beforeEach(() => {
-    global.__resourceQuery = 'foo';
+    // make this an empty string so that it works on Node when we need
+    // to redirect the __resourceQuery to another file,
+    // e.g. require(`./index${__resourceQuery}`) will not work with Node
+    // unless __resourceQuery === ''
+    global.__resourceQuery = '';
     self.location.reload = jest.fn();
 
     // log
-    jest.setMock('../../client-src/default/utils/log.js', {
+    jest.setMock('../../client/default/utils/log.js', {
       log: {
         info: jest.fn(),
         warn: jest.fn(),
         error: jest.fn(),
       },
     });
-    log = require('../../client-src/default/utils/log');
+    log = require('../../client/utils/log');
 
     // socket
-    jest.setMock('../../client-src/default/socket.js', jest.fn());
-    socket = require('../../client-src/default/socket');
+    jest.setMock('../../client/default/socket.js', jest.fn());
+    socket = require('../../client/socket');
 
     // overlay
-    jest.setMock('../../client-src/default/overlay.js', {
+    jest.setMock('../../client/default/overlay.js', {
       clear: jest.fn(),
       showMessage: jest.fn(),
     });
-    overlay = require('../../client-src/default/overlay');
+    overlay = require('../../client/overlay');
 
     // reloadApp
-    jest.setMock('../../client-src/default/utils/reloadApp.js', jest.fn());
-    reloadApp = require('../../client-src/default/utils/reloadApp');
+    jest.setMock('../../client/default/utils/reloadApp.js', jest.fn());
+    reloadApp = require('../../client/utils/reloadApp');
 
     // sendMessage
-    jest.setMock('../../client-src/default/utils/sendMessage.js', jest.fn());
-    sendMessage = require('../../client-src/default/utils/sendMessage');
+    jest.setMock('../../client/default/utils/sendMessage.js', jest.fn());
+    sendMessage = require('../../client/utils/sendMessage');
 
     // createSocketUrl
     jest.setMock(
-      '../../client-src/default/utils/createSocketUrl.js',
+      '../../client/default/utils/createSocketUrl.js',
       () => 'mock-url'
     );
 
-    require('../../client-src/default');
+    require('../../client/index');
     onSocketMessage = socket.mock.calls[0][1];
   });
 

test/client/overlay.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const overlay = require('../../client-src/default/overlay');
+const overlay = require('../../client/overlay');
 
 describe('overlay', () => {
   it('should run showMessage', () => {

test/client/utils/createSocketUrl.test.js

@@ -17,12 +17,12 @@ describe('createSocketUrl', () => {
 
   samples.forEach((url) => {
     jest.doMock(
-      '../../../client-src/default/utils/getCurrentScriptSource.js',
+      '../../../client/default/utils/getCurrentScriptSource.js',
       () => () => url
     );
 
     // eslint-disable-next-line global-require
-    const createSocketUrl = require('../../../client-src/default/utils/createSocketUrl');
+    const createSocketUrl = require('../../../client/utils/createSocketUrl');
 
     test(`should return the url when __resourceQuery is ${url}`, () => {
       expect(createSocketUrl(url)).toMatchSnapshot();

test/client/utils/getCurrentScriptSource.test.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const getCurrentScriptSource = require('../../../client-src/default/utils/getCurrentScriptSource');
+const getCurrentScriptSource = require('../../../client/utils/getCurrentScriptSource');
 
 describe('getCurrentScriptSource', () => {
   afterEach(() => {

test/client/utils/log.test.js

@@ -18,7 +18,7 @@ describe('log', () => {
     });
 
     // eslint-disable-next-line global-require
-    setLogLevel = require('../../../client-src/default/utils/log').setLogLevel;
+    setLogLevel = require('../../../client/utils/log').setLogLevel;
   });
 
   afterEach(() => {

test/client/utils/reloadApp.test.js

@@ -25,7 +25,7 @@ describe('reloadApp', () => {
     });
 
     // eslint-disable-next-line global-require
-    reloadApp = require('../../../client-src/default/utils/reloadApp');
+    reloadApp = require('../../../client/utils/reloadApp');
   });
 
   afterEach(() => {

test/client/utils/sendMessage.test.js

@@ -2,7 +2,7 @@
 
 /* global self */
 
-const sendMessage = require('../../../client-src/default/utils/sendMessage');
+const sendMessage = require('../../../client/utils/sendMessage');
 
 describe('sendMessage', () => {
   afterEach(() => {