Search onDidChangeResults event should return count 0, index -1 when there are no results #3832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

Tyriar opened this issue May 26, 2022 · 0 comments · Fixed by #3874

Assignees

Labels

area/addon/search area/api type/bug

Member

Tyriar commented May 26, 2022

Current count gets set to -1

Tyriar added type/bug area/api area/addon/search labels

Tyriar added this to the 4.19.0 milestone

Tyriar assigned Tyriar and meganrogge

Tyriar removed this from the 4.19.0 milestone

meganrogge added a commit to meganrogge/xterm.js that referenced this issue


          xtermjs#3832

92fd18f

meganrogge mentioned this issue

return 0 instead of -1 for no result find count #3874

Merged

meganrogge closed this as completed in #3874

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment