Skip to content

264 call be to delete directory #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions server/app/routes/directory.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ def create_directory():
directory_path = data.get('directoryPath', None)
return Directory.create_directory(directory_path=directory_path)

@directory_blueprint.route('/directory/<path:directory_path>', methods=['DELETE'])
def delete_directory(directory_path):
return Directory.delete_directory_by_path(directory_path=directory_path)

@directory_blueprint.route('/directory/<path:directory_path>', methods=['PATCH'])
def rename_directory(directory_path):
data = request.get_json()
Expand Down
33 changes: 33 additions & 0 deletions server/app/services/directory.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,39 @@ def create_directory(directory_path: str = None) -> None:
status=response.status_code,
mimetype='application/json'
)

@staticmethod
def delete_directory_by_path(directory_path: str = None):
jupyter_api_path = app.config['JUPYTER_API_PATH']

path = f"{jupyter_api_path}/{directory_path}"
response = requests.delete(path)

if response.status_code != 204:
return Response(
response=({'message': 'Failed to delete in jupyter server'}),
status=404)

directory = DirectoryModel.query.filter_by(path=directory_path).first()

if directory is None:
# If no directory was found with the given path, return a 404 error
return Response(
response=json.dumps({'message': 'Directory not found in DB'}),
status=404)

# Delete the directory
try:
db.session.delete(directory)
db.session.commit()
except Exception as e:
return Response(
response=json.dumps({'message': 'Error deleting directory in DB: ' + str(e)}),
status=404)

return Response(
response=json.dumps({'message': 'Directory deleted'}),
status=200)

@staticmethod
def rename_directory_by_path(directory_path: str = None, new_directory_path: str = None):
Expand Down
18 changes: 18 additions & 0 deletions server/tests/services/test_directory_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,24 @@ def test_create_directory(self):
self.assertEqual(len(json.loads(response_2.data)['content']), 1)
self.assertEqual(json.loads(response_2.data)['content'][0]['name'], 'test_directory')

def test_delete_directory_by_path(self):
with self.app.app_context():

# Create directory
response_0 = Directory.create_directory('work/test_directory')
directoryFromDB = DirectoryModel.query.filter_by(path='work/test_directory').first()
self.assertIsNotNone(directoryFromDB)
self.assertEqual(directoryFromDB.name, 'test_directory')

# Delete directory
response_1 = Directory.delete_directory_by_path('work/test_directory')
self.assertEqual(response_1.status_code, 200)

# Check if deleted directory could not be detected
response_2 = Directory.get_content_by_path('work')
self.assertEqual(response_2.status_code, 200)
self.assertEqual(json.loads(response_2.data)['content'], [])

def test_rename_directory_by_path(self):
with self.app.app_context():

Expand Down
2 changes: 1 addition & 1 deletion webapp/src/components/sidebar/workspace/item/MoreButton.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const MoreButton = ({
const handleDelete = async (baseUrl, file) => {
console.log('Delete:', file);
try {
await DirectoryModel.deleteItem(baseUrl, file);
await DirectoryModel.deleteDirectory(file);
} catch (error) {
console.error('Failed to delete item:', error);
}
Expand Down
40 changes: 20 additions & 20 deletions webapp/src/models/DirectoryModel.js
Original file line number Diff line number Diff line change
Expand Up @@ -80,30 +80,30 @@ class DirectoryModel {
});
}

static async deleteItem(basePath = '', item = '') {
const itemPath = basePath + item.path;
if (item.type === 'notebook') {
NotebookModel.deleteNotebook(item.path);
static async deleteDirectory(item = '') {
const itemPath = item.path;

let folderItems = [];
await DirectoryModel.getChildren(itemPath)
.then((data) => {
folderItems = data;
})
if (folderItems.length > 0) {
alert('Directory is not empty');
} else {
let folderItems = [];
await DirectoryModel.getChildren(itemPath)
.then((data) => {
folderItems = data;
})
if (folderItems.length > 0) {
alert('Directory is not empty');
} else {
console.log("Deleting item at path:", itemPath);
try {
const response = await fetch(itemPath, {
method: 'DELETE'
});
} catch (error) {
alert(`Failed to delete directory: ${error.message}`);
console.log("Deleting item at path:", itemPath);
try {
const response = await fetch("http://localhost:5002/directory/" + itemPath, {
method: 'DELETE',
});
if (!response.ok) {
throw new Error('Failed to delete directory');
}
} catch (error) {
alert(`Failed to delete directory: ${error.message}`);
}
}
}
}

}

Expand Down
Loading