Skip to content

merge dev to main (v2.1.1) #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "zenstack-monorepo",
"version": "2.1.0",
"version": "2.1.1",
"description": "",
"scripts": {
"build": "pnpm -r build",
Expand Down
5 changes: 5 additions & 0 deletions packages/ide/jetbrains/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

## [Unreleased]
### Added
- Support using ZModel type names (e.g., `DateTime`) as model field names.
- `auth()` is resolved from all reachable schema files.

## 2.0.0
### Added
- ZenStack V2 release!

## 1.11.0
Expand Down
2 changes: 1 addition & 1 deletion packages/ide/jetbrains/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ plugins {
}

group = "dev.zenstack"
version = "2.1.0"
version = "2.1.1"

repositories {
mavenCentral()
Expand Down
2 changes: 1 addition & 1 deletion packages/ide/jetbrains/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "jetbrains",
"version": "2.1.0",
"version": "2.1.1",
"displayName": "ZenStack JetBrains IDE Plugin",
"description": "ZenStack JetBrains IDE plugin",
"homepage": "https://zenstack.dev",
Expand Down
2 changes: 1 addition & 1 deletion packages/language/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@zenstackhq/language",
"version": "2.1.0",
"version": "2.1.1",
"displayName": "ZenStack modeling language compiler",
"description": "ZenStack modeling language compiler",
"homepage": "https://zenstack.dev",
Expand Down
2 changes: 1 addition & 1 deletion packages/misc/redwood/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@zenstackhq/redwood",
"displayName": "ZenStack RedwoodJS Integration",
"version": "2.1.0",
"version": "2.1.1",
"description": "CLI and runtime for integrating ZenStack with RedwoodJS projects.",
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/openapi/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@zenstackhq/openapi",
"displayName": "ZenStack Plugin and Runtime for OpenAPI",
"version": "2.1.0",
"version": "2.1.1",
"description": "ZenStack plugin and runtime supporting OpenAPI",
"main": "index.js",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/swr/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@zenstackhq/swr",
"displayName": "ZenStack plugin for generating SWR hooks",
"version": "2.1.0",
"version": "2.1.1",
"description": "ZenStack plugin for generating SWR hooks",
"main": "index.js",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/tanstack-query/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@zenstackhq/tanstack-query",
"displayName": "ZenStack plugin for generating tanstack-query hooks",
"version": "2.1.0",
"version": "2.1.1",
"description": "ZenStack plugin for generating tanstack-query hooks",
"main": "index.js",
"exports": {
Expand Down
2 changes: 1 addition & 1 deletion packages/plugins/trpc/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@zenstackhq/trpc",
"displayName": "ZenStack plugin for tRPC",
"version": "2.1.0",
"version": "2.1.1",
"description": "ZenStack plugin for tRPC",
"main": "index.js",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/runtime/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@zenstackhq/runtime",
"displayName": "ZenStack Runtime Library",
"version": "2.1.0",
"version": "2.1.1",
"description": "Runtime of ZenStack for both client-side and server-side environments.",
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion packages/runtime/res/enhance.d.ts
Original file line number Diff line number Diff line change
@@ -1 +1 @@
export { enhance } from '.zenstack/enhance';
export { auth, enhance } from '.zenstack/enhance';
18 changes: 11 additions & 7 deletions packages/runtime/src/enhancements/policy/policy-utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -960,13 +960,9 @@ export class PolicyUtil extends QueryUtils {
* @returns
*/
injectReadCheckSelect(model: string, args: any) {
if (this.hasFieldLevelPolicy(model)) {
// recursively inject selection for fields needed for field-level read checks
const readFieldSelect = this.getReadFieldSelect(model);
if (readFieldSelect) {
this.doInjectReadCheckSelect(model, args, { select: readFieldSelect });
}
}
// we need to recurse into relation fields before injecting the current level, because
// injection into current level can result in relation being selected/included, which
// can then cause infinite recursion when we visit relation later

// recurse into relation fields
for (const [k, v] of Object.entries<any>(args.select ?? args.include ?? {})) {
Expand All @@ -975,6 +971,14 @@ export class PolicyUtil extends QueryUtils {
this.injectReadCheckSelect(field.type, v);
}
}

if (this.hasFieldLevelPolicy(model)) {
// recursively inject selection for fields needed for field-level read checks
const readFieldSelect = this.getReadFieldSelect(model);
if (readFieldSelect) {
this.doInjectReadCheckSelect(model, args, { select: readFieldSelect });
}
}
}

private doInjectReadCheckSelect(model: string, args: any, input: any) {
Expand Down
2 changes: 1 addition & 1 deletion packages/schema/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"publisher": "zenstack",
"displayName": "ZenStack Language Tools",
"description": "Build scalable web apps with minimum code by defining authorization and validation rules inside the data schema that closer to the database",
"version": "2.1.0",
"version": "2.1.1",
"author": {
"name": "ZenStack Team"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/sdk/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@zenstackhq/sdk",
"version": "2.1.0",
"version": "2.1.1",
"description": "ZenStack plugin development SDK",
"main": "index.js",
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/server/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@zenstackhq/server",
"version": "2.1.0",
"version": "2.1.1",
"displayName": "ZenStack Server-side Adapters",
"description": "ZenStack server-side adapters",
"homepage": "https://zenstack.dev",
Expand Down
2 changes: 1 addition & 1 deletion packages/testtools/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@zenstackhq/testtools",
"version": "2.1.0",
"version": "2.1.1",
"description": "ZenStack Test Tools",
"main": "index.js",
"private": true,
Expand Down
58 changes: 58 additions & 0 deletions tests/regression/tests/issue-1451.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
import { loadSchema } from '@zenstackhq/testtools';

describe('issue 1452', () => {
it('regression', async () => {
const { prisma, enhance } = await loadSchema(
`
model User {
id String @id
memberships Membership[]
}

model Space {
id String @id
memberships Membership[]
}

model Membership {
userId String
user User @relation(fields: [userId], references: [id], onDelete: Cascade)
spaceId String
space Space @relation(fields: [spaceId], references: [id], onDelete: Cascade)

role String @deny("update", auth() == user)
employeeReference String? @deny("read, update", space.memberships?[auth() == user && !(role in ['owner', 'admin'])])

createdAt DateTime @default(now())
updatedAt DateTime @updatedAt

@@id([userId, spaceId])
@@allow('all', true)
}
`,
{ logPrismaQuery: true }
);

await prisma.user.create({
data: { id: '1' },
});

await prisma.space.create({
data: { id: '1' },
});

await prisma.membership.create({
data: {
user: { connect: { id: '1' } },
space: { connect: { id: '1' } },
role: 'foo',
employeeReference: 'xyz',
},
});

const db = enhance({ id: '1' });
const r = await db.membership.findMany();
expect(r).toHaveLength(1);
expect(r[0].employeeReference).toBeUndefined();
});
});
Loading