-
-
Notifications
You must be signed in to change notification settings - Fork 111
attempt CI fix #2133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attempt CI fix #2133
Conversation
📝 WalkthroughWalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant run()
participant execSync
Caller->>run(): invoke run(command, options)
run->>execSync: execSync(command, options)
alt success
execSync-->>run(): result
run-->>Caller: return result
else error
run-->>run(): log error
run->>execSync: execSync(command, { stdio: 'inherit', ...options })
execSync-->>run(): (output displayed in real time)
run-->>Caller: throw original error
end
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (5)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/testtools/src/schema.ts (1)
45-63
: Good improvement for CI debugging visibility!The added fallback execution with
stdio: 'inherit'
is a smart approach for CI environments. When the initial command fails, running it again with inherited IO streams will display the output in real-time in CI logs, making it much easier to diagnose failures.Consider adding a brief comment explaining the rationale for this pattern to help future developers understand why the command is executed twice in failure scenarios:
catch (err) { console.error('Command failed:', cmd, err); + // Re-run with inherited stdio to show output in real-time for CI debugging execSync(cmd, { stdio: 'inherit', encoding: 'utf-8', env: { ...process.env, DO_NOT_TRACK: '1', ...env }, cwd, }); throw err; }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
packages/testtools/src/schema.ts
(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
packages/testtools/src/schema.ts (1)
packages/schema/src/utils/exec-utils.ts (1)
execSync
(6-10)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: dependency-review
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: build-test (20.x)
- GitHub Check: build-test (20.x)
- GitHub Check: build-test (20.x)
- GitHub Check: OSSAR-Scan
No description provided.