fix date string zod validation #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ymc9
reviewed
Apr 18, 2023
| @@ -114,7 +114,7 @@ export default class Transformer { | |||
| } else if (inputType.type === 'Boolean') { | |||
| result.push(this.wrapWithZodValidators('z.boolean()', field, inputType)); | |||
| } else if (inputType.type === 'DateTime') { | |||
| result.push(this.wrapWithZodValidators('z.date()', field, inputType)); | |||
| result.push(this.wrapWithZodValidators('z.union([z.date(), z.string().datetime()])', field, inputType)); | |||
There was a problem hiding this comment.
Hey, thanks for working on this @Xemah !
I tried it out, and there's a problem with the distribution of union over array:
Here the inferred type doesn't conform to Prisma filter's typing. The union needs to wrap around array. Maybe we should refactor wrapWithZodValidators and and pass in a list of validators so we can deal with the array distribution inside of it?
There was a problem hiding this comment.
Maybe, we have to do like if its a union, then use '.array()' for each of the rule inside union
Like if it's z.union([z.date(), z.string().datetime()]), it should do z.union([z.date().array(), z.string().datetime().array()])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.