Skip to content

Decrease whitespace at end of message feed #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Decrease whitespace at end of message feed #1628

wants to merge 4 commits into from

Conversation

chrisbobbe
Copy link
Collaborator

This does two things:

Proposed by Tim in chat:

#mobile > space at end of thread @ 💬

I bet those two tweaks might fully address this issue.

Screenshots coming soon.

@chrisbobbe
msglist: Decrease end-of-feed gap from 36px to 12px
83dfd96 
See discussion linked in the comment.
@chrisbobbe
msglist [nfc]: Make a common codepath for prevMessage != null
f060dc0 
I.e., the top of the `else` that belongs to the
`if (prevMessage == null)`. We'll use this to implement
MessageListMessageBaseItem.isLastInFeed, coming up.
@chrisbobbe
msglist [nfc]: Pull out some asserts that also apply when haveSameRec…
cd7a9ea 
…ipient

These invariants apply regardless of `haveSameRecipient`.
@chrisbobbe
msglist: Remove 11px bottom padding in MessageItem at end of feed
15b7af9 
See discussions:
  zulip#1453 (comment)
  https://chat.zulip.org/#narrow/channel/48-mobile/topic/space.20at.20end.20of.20thread/near/2203417
@chrisbobbe chrisbobbe added the launch feedback Things users specifically asked for upon launch label Jun 24, 2025
@chrisbobbe
Copy link
Collaborator Author

chrisbobbe commented Jun 24, 2025 •
edited
Loading

Dark mode:

Before After
image image
image image
image image

@chrisbobbe
Copy link
Collaborator Author

Light mode:

Before After
image image
image image
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
launch feedback Things users specifically asked for upon launch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chrisbobbe