-
Notifications
You must be signed in to change notification settings - Fork 251
Binho Nova integration #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9690546
Added support for Binho Nova Multi-Protocol USB Host Adapter
jonathan-binho e6925ab
Have Binho use its own try block
fig1010 2f3ffab
Use BLINKA_NOVA as env variable instead
fig1010 903fc78
change board id to NOVA and fix issue with autodetect being called mu…
fig1010 95e159f
set _binho only if BLINKA_NOVA env variable exists
fig1010 d09621e
Use binho connection singleton
fig1010 0d67ae6
Added support for Binho Nova Multi-Protocol USB Host Adapter
jonathan-binho 86c9931
Use BLINKA_NOVA as env variable instead
fig1010 bf78cc6
change board id to NOVA and fix issue with autodetect being called mu…
fig1010 9c68446
set _binho only if BLINKA_NOVA env variable exists
fig1010 5084033
Use binho connection singleton
fig1010 6cde03a
Merge branch 'master' of https://github.com/binhollc/Adafruit_Python_…
fig1010 0a1c8ff
Clean up and remove unused code
fig1010 ea802ab
Fix Comparison expr is None check from pylint
fig1010 6f7af39
Rename board to BINHO_NOVA
fig1010 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only concern on this PR is that there's another board named Nova that will be added in the future. Can we change the string from
"NOVA"
to"BINHO_NOVA"
? Otherwise, everything else looks good to me too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, sure. I can make this change to use "BINHO_NOVA" instead. Thanks for the heads up!